From bb68605c69127a005679e657a3c1cea76c5b0292 Mon Sep 17 00:00:00 2001 From: ghubstan <36207203+ghubstan@users.noreply.github.com> Date: Fri, 3 Dec 2021 12:13:33 -0300 Subject: [PATCH 1/2] Add missing --currency-code=bsq param to createoffer example Resolves issue mentioned in https://github.com/bisq-network/bisq/pull/5876#pullrequestreview-822692137 --- apitest/docs/api-beta-test-guide.md | 1 + 1 file changed, 1 insertion(+) diff --git a/apitest/docs/api-beta-test-guide.md b/apitest/docs/api-beta-test-guide.md index 6ed00c6990..5eb57131f0 100644 --- a/apitest/docs/api-beta-test-guide.md +++ b/apitest/docs/api-beta-test-guide.md @@ -379,6 +379,7 @@ $ ./bisq-cli --password=xyz --port=9998 createoffer \ --swap=true \ --direction=BUY \ --amount=0.5 \ + --currency-code=BSQ \ --fixed-price=0.00005 ``` From f195b76637ec2945d9479491306425a5631441f8 Mon Sep 17 00:00:00 2001 From: ghubstan <36207203+ghubstan@users.noreply.github.com> Date: Fri, 3 Dec 2021 12:47:03 -0300 Subject: [PATCH 2/2] Tell user bsqswap offer cannot be edited, but can be canceled at no charge Resolves issue described in https://github.com/bisq-network/bisq/pull/5876#pullrequestreview-822692137 --- cli/src/main/java/bisq/cli/CliMain.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cli/src/main/java/bisq/cli/CliMain.java b/cli/src/main/java/bisq/cli/CliMain.java index fc77205bca..5689fbdad0 100644 --- a/cli/src/main/java/bisq/cli/CliMain.java +++ b/cli/src/main/java/bisq/cli/CliMain.java @@ -378,7 +378,8 @@ public class CliMain { var offerId = offerIdOpt.getOfferId(); var offerCategory = client.getMyOfferCategory(offerId); if (offerCategory.equals(BSQ_SWAP)) - throw new IllegalStateException("cannot edit swap bsq offers"); + throw new IllegalStateException("bsq swap offers cannot be edited," + + " but you may cancel them without forfeiting any funds"); var opts = new EditOfferOptionParser(args).parse(); var fixedPrice = opts.getFixedPrice();