From c842575ebae466032aeaea0596c018beaaae74eb Mon Sep 17 00:00:00 2001 From: Devin Bileck <603793+devinbileck@users.noreply.github.com> Date: Thu, 21 Mar 2019 10:44:20 -0700 Subject: [PATCH] Fix BTC status incorrectly hidden on splash screen Issue: When launching a new Bisq instance (i.e. new data directory) and remaining on the user agreement screen for >90 seconds while reading it, once you accept the agreement the BTC status was not being shown on the splash screen. Cause: showTorNetworkSettingsTimer gets triggered after 90 seconds and since Tor is not started until after accepting the user agreement, it was incorrectly assuming that Tor is not working and as a result hiding the BTC status. Fix: Don't hide the BTC status in showTorNetworkSettingsTimer. If there is an issue with Tor, splashP2PNetworkErrorMsgListener handles hiding the BTC status. --- desktop/src/main/java/bisq/desktop/main/MainView.java | 5 ----- 1 file changed, 5 deletions(-) diff --git a/desktop/src/main/java/bisq/desktop/main/MainView.java b/desktop/src/main/java/bisq/desktop/main/MainView.java index ba6fd2ee3c..c71bdede63 100644 --- a/desktop/src/main/java/bisq/desktop/main/MainView.java +++ b/desktop/src/main/java/bisq/desktop/main/MainView.java @@ -610,11 +610,6 @@ public class MainView extends InitializableView { Timer showTorNetworkSettingsTimer = UserThread.runAfter(() -> { showTorNetworkSettingsButton.setVisible(true); showTorNetworkSettingsButton.setManaged(true); - if (btcSyncIndicator.progressProperty().getValue() <= 0) { - // If no progress has been made, hide the BTC status since tor is not working - btcSyncIndicator.setVisible(false); - btcSplashInfo.setVisible(false); - } }, SHOW_TOR_SETTINGS_DELAY_SEC); splashP2PNetworkIconIdListener = (ov, oldValue, newValue) -> {