Fix codacy problems

Unnecessary use of fully qualified name 'System.exit' due to existing
static import 'java.lang.System.exit'.  (line 100)

Avoid throwing raw exception types.  (lines 295, 302)
This commit is contained in:
ghubstan 2020-07-09 16:49:16 -03:00
parent 2cd80aaa60
commit 09929c833f
No known key found for this signature in database
GPG key ID: E35592D6800A861E

View file

@ -37,6 +37,7 @@ import static bisq.apitest.config.BisqAppConfig.*;
import static java.lang.String.format; import static java.lang.String.format;
import static java.lang.System.err; import static java.lang.System.err;
import static java.lang.System.exit; import static java.lang.System.exit;
import static java.lang.System.out;
import static java.util.concurrent.TimeUnit.SECONDS; import static java.util.concurrent.TimeUnit.SECONDS;
@ -92,12 +93,12 @@ public class ApiTestMain {
config = new ApiTestConfig(args); config = new ApiTestConfig(args);
if (config.helpRequested) { if (config.helpRequested) {
config.printHelp(System.out, config.printHelp(out,
new BisqHelpFormatter( new BisqHelpFormatter(
"Bisq ApiTest", "Bisq ApiTest",
"bisq-apitest", "bisq-apitest",
"0.1.0")); "0.1.0"));
System.exit(EXIT_SUCCESS); exit(EXIT_SUCCESS);
} }
// Start each background process from an executor, then add a shutdown hook. // Start each background process from an executor, then add a shutdown hook.
@ -292,13 +293,13 @@ public class ApiTestMain {
bitcoindTask.getLinuxProcess().shutdown(); bitcoindTask.getLinuxProcess().shutdown();
} catch (Exception ex) { } catch (Exception ex) {
throw new RuntimeException(ex); throw new IllegalStateException(ex);
} }
})); }));
} }
private void verifyNotWindows() { private void verifyNotWindows() {
if (Utilities.isWindows()) if (Utilities.isWindows())
throw new RuntimeException("ApiTest not supported on Windows"); throw new IllegalStateException("ApiTest not supported on Windows");
} }
} }