Merge pull request #7675 from BlueWallet/revert-7631-headr

Revert "REF: Wallet tranaction header animation"
This commit is contained in:
GLaDOS 2025-03-04 11:13:29 +00:00 committed by GitHub
commit c967f6701a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
9 changed files with 194 additions and 158 deletions

View file

@ -170,7 +170,7 @@ const TransactionsNavigationHeader: React.FC<TransactionsNavigationHeaderProps>
>
<Image source={imageSource} style={styles.chainIcon} />
<Text testID="WalletLabel" numberOfLines={2} style={styles.walletLabel} selectable>
<Text testID="WalletLabel" numberOfLines={1} style={styles.walletLabel} selectable>
{wallet.getLabel()}
</Text>
<View style={styles.walletBalanceAndUnitContainer}>

View file

@ -10,7 +10,7 @@ import { useCallback, useMemo } from 'react';
const requiresBiometrics = [
'WalletExportRoot',
'WalletXpubRoot',
'ViewEditMultisigCosigners',
'ViewEditMultisigCosignersRoot',
'ExportMultisigCoordinationSetupRoot',
];

View file

@ -35,6 +35,7 @@ import ReceiveDetailsStackRoot from './ReceiveDetailsStack';
import ScanLndInvoiceRoot from './ScanLndInvoiceStack';
import SendDetailsStack from './SendDetailsStack';
import SignVerifyStackRoot from './SignVerifyStack';
import ViewEditMultisigCosignersStackRoot from './ViewEditMultisigCosignersStack';
import WalletExportStack from './WalletExportStack';
import WalletXpubStackRoot from './WalletXpubStack';
import SettingsButton from '../components/icons/SettingsButton';
@ -65,7 +66,6 @@ import ToolsScreen from '../screen/settings/tools';
import SettingsPrivacy from '../screen/settings/SettingsPrivacy';
import { ScanQRCodeComponent } from './LazyLoadScanQRCodeStack';
import { useIsLargeScreen } from '../hooks/useIsLargeScreen';
import { ViewEditMultisigCosignersComponent } from './LazyLoadViewEditMultisigCosignersStack';
const DetailViewStackScreensStack = () => {
const theme = useTheme();
@ -342,8 +342,8 @@ const DetailViewStackScreensStack = () => {
/>
<DetailViewStack.Screen
name="ViewEditMultisigCosigners"
component={ViewEditMultisigCosignersComponent}
name="ViewEditMultisigCosignersRoot"
component={ViewEditMultisigCosignersStackRoot}
options={{ ...NavigationDefaultOptions, ...StatusBarLightOptions, gestureEnabled: false, fullScreenGestureEnabled: false }}
initialParams={{ walletID: undefined, cosigners: undefined }}
/>

View file

@ -79,7 +79,7 @@ export type DetailViewStackParamList = {
ReleaseNotes: undefined;
ToolsScreen: undefined;
SettingsPrivacy: undefined;
ViewEditMultisigCosigners: { walletID: string; cosigners: string[]; onBarScanned?: string };
ViewEditMultisigCosignersRoot: { walletID: string; cosigners: string[] };
WalletXpubRoot: undefined;
SignVerifyRoot: {
screen: 'SignVerify';

View file

@ -0,0 +1,48 @@
import { createNativeStackNavigator } from '@react-navigation/native-stack';
import React from 'react';
import navigationStyle from '../components/navigationStyle';
import { useTheme } from '../components/themes';
import loc from '../loc';
import { ViewEditMultisigCosignersComponent } from './LazyLoadViewEditMultisigCosignersStack';
import { ScanQRCodeComponent } from './LazyLoadScanQRCodeStack';
import { ScanQRCodeParamList } from './DetailViewStackParamList';
export type ViewEditMultisigCosignersStackParamList = {
ViewEditMultisigCosigners: {
walletID: string;
onBarScanned?: string;
};
ScanQRCode: ScanQRCodeParamList;
};
const Stack = createNativeStackNavigator<ViewEditMultisigCosignersStackParamList>();
const ViewEditMultisigCosignersStackRoot = () => {
const theme = useTheme();
return (
<Stack.Navigator screenOptions={{ headerShadowVisible: false }}>
<Stack.Screen
name="ViewEditMultisigCosigners"
component={ViewEditMultisigCosignersComponent}
options={navigationStyle({
headerBackVisible: false,
title: loc.multisig.manage_keys,
})(theme)}
/>
<Stack.Screen
name="ScanQRCode"
component={ScanQRCodeComponent}
options={navigationStyle({
headerShown: false,
statusBarHidden: true,
presentation: 'fullScreenModal',
headerShadowVisible: false,
})(theme)}
/>
</Stack.Navigator>
);
};
export default ViewEditMultisigCosignersStackRoot;

View file

@ -1,5 +1,5 @@
import React, { useCallback, useEffect, useMemo, useRef, useState } from 'react';
import { RouteProp, useFocusEffect, useRoute, usePreventRemove, StackActions } from '@react-navigation/native';
import { RouteProp, useFocusEffect, useRoute, usePreventRemove, CommonActions } from '@react-navigation/native';
import {
ActivityIndicator,
Alert,
@ -18,15 +18,7 @@ import {
import { Badge, Icon } from '@rneui/themed';
import { isDesktop } from '../../blue_modules/environment';
import { encodeUR } from '../../blue_modules/ur';
import {
BlueCard,
BlueFormMultiInput,
BlueLoading,
BlueSpacing10,
BlueSpacing20,
BlueSpacing40,
BlueTextCentered,
} from '../../BlueComponents';
import { BlueCard, BlueFormMultiInput, BlueLoading, BlueSpacing10, BlueSpacing20, BlueTextCentered } from '../../BlueComponents';
import { HDSegwitBech32Wallet, MultisigCosigner, MultisigHDWallet } from '../../class';
import presentAlert from '../../components/Alert';
import BottomModal, { BottomModalHandle } from '../../components/BottomModal';
@ -48,14 +40,14 @@ import { useStorage } from '../../hooks/context/useStorage';
import ToolTipMenu from '../../components/TooltipMenu';
import { CommonToolTipActions } from '../../typings/CommonToolTipActions';
import { useSettings } from '../../hooks/context/useSettings';
import { ViewEditMultisigCosignersStackParamList } from '../../navigation/ViewEditMultisigCosignersStack';
import { NativeStackNavigationProp } from '@react-navigation/native-stack';
import SafeArea from '../../components/SafeArea';
import { TWallet } from '../../class/wallets/types';
import { AddressInputScanButton } from '../../components/AddressInputScanButton';
import { DetailViewStackParamList } from '../../navigation/DetailViewStackParamList';
type RouteParams = RouteProp<DetailViewStackParamList, 'ViewEditMultisigCosigners'>;
type NavigationProp = NativeStackNavigationProp<DetailViewStackParamList, 'ViewEditMultisigCosigners'>;
type RouteParams = RouteProp<ViewEditMultisigCosignersStackParamList, 'ViewEditMultisigCosigners'>;
type NavigationProp = NativeStackNavigationProp<ViewEditMultisigCosignersStackParamList, 'ViewEditMultisigCosigners'>;
const ViewEditMultisigCosigners: React.FC = () => {
const hasLoaded = useRef(false);
@ -177,11 +169,9 @@ const ViewEditMultisigCosigners: React.FC = () => {
setIsSaveButtonDisabled(true);
setWalletsWithNewOrder(newWallets);
setTimeout(() => {
const popTo = StackActions.popTo('WalletTransactions', {
walletID,
walletType: wallet.type,
});
dispatch(popTo);
dispatch(
CommonActions.navigate({ name: 'WalletTransactions', params: { walletID: wallet.getID(), walletType: MultisigHDWallet.type } }),
);
}, 500);
}, 100);
};
@ -570,7 +560,6 @@ const ViewEditMultisigCosigners: React.FC = () => {
{!isLoading && (
<>
<BlueSpacing40 />
<AddressInputScanButton
beforePress={async () => {
await provideMnemonicsModalRef.current?.dismiss();
@ -579,7 +568,7 @@ const ViewEditMultisigCosigners: React.FC = () => {
type="link"
onChangeText={setImportText}
/>
<BlueSpacing40 />
<BlueSpacing20 />
</>
)}
</>

View file

@ -37,7 +37,7 @@ import { useExtendedNavigation } from '../../hooks/useExtendedNavigation';
import loc, { formatBalanceWithoutSuffix } from '../../loc';
import { BitcoinUnit, Chain } from '../../models/bitcoinUnits';
import { useStorage } from '../../hooks/context/useStorage';
import { useFocusEffect, useRoute, RouteProp, usePreventRemove, CommonActions } from '@react-navigation/native';
import { useFocusEffect, useRoute, RouteProp, usePreventRemove } from '@react-navigation/native';
import { LightningTransaction, Transaction, TWallet } from '../../class/wallets/types';
import { DetailViewStackParamList } from '../../navigation/DetailViewStackParamList';
import HeaderMenuButton from '../../components/HeaderMenuButton';
@ -66,7 +66,7 @@ const WalletDetails: React.FC = () => {
const [hideTransactionsInWalletsList, setHideTransactionsInWalletsList] = useState<boolean>(
wallet.getHideTransactionsInWalletsList ? !wallet.getHideTransactionsInWalletsList() : true,
);
const { setOptions, navigate, dispatch } = useExtendedNavigation();
const { setOptions, navigate } = useExtendedNavigation();
const { colors } = useTheme();
const [walletName, setWalletName] = useState<string>(wallet.getLabel());
@ -305,11 +305,13 @@ const WalletDetails: React.FC = () => {
});
};
const navigateToViewEditCosigners = () => {
navigate('ViewEditMultisigCosigners', {
walletID,
navigate('ViewEditMultisigCosignersRoot', {
screen: 'ViewEditMultisigCosigners',
params: {
walletID,
},
});
};
const navigateToXPub = () =>
navigate('WalletXpubRoot', {
screen: 'WalletXpub',
@ -393,28 +395,6 @@ const WalletDetails: React.FC = () => {
wallet._hdWalletInstance._lastTxFetch = 0;
// @ts-expect-error: Need to fix later
wallet._hdWalletInstance._lastBalanceFetch = 0;
// Find the WalletTransactions screen in the navigation state and reset just that screen.
// It can be multiple WalletTransactions screen.
dispatch(state => {
// Find the route that contains 'WalletTransactions' in the navigation stack
const routes = state.routes.map(route => {
if (route.name === 'WalletTransactions' && (route.params as { walletID: string })?.walletID === walletID) {
// Reset this specific route with the same params to force a refresh
return {
...route,
key: `WalletTransactions-${walletID}-${Date.now()}`, // Force new key to ensure fresh mount
};
}
return route;
});
return CommonActions.reset({
...state,
routes,
index: state.index,
});
});
presentAlert({ message: msg });
}
};

View file

@ -5,15 +5,16 @@ import {
Alert,
Dimensions,
findNodeHandle,
FlatList,
I18nManager,
InteractionManager,
LayoutAnimation,
PixelRatio,
ScrollView,
StyleSheet,
Text,
View,
Animated,
LayoutChangeEvent,
RefreshControl,
} from 'react-native';
import { Icon } from '@rneui/themed';
import * as BlueElectrum from '../../blue_modules/BlueElectrum';
@ -37,6 +38,7 @@ import { NativeStackScreenProps } from '@react-navigation/native-stack';
import { DetailViewStackParamList } from '../../navigation/DetailViewStackParamList';
import { Transaction, TWallet } from '../../class/wallets/types';
import getWalletTransactionsOptions from '../../navigation/helpers/getWalletTransactionsOptions';
import { presentWalletExportReminder } from '../../helpers/presentWalletExportReminder';
import selectWallet from '../../helpers/select-wallet';
import assert from 'assert';
import useMenuElements from '../../hooks/useMenuElements';
@ -44,6 +46,7 @@ import { useSettings } from '../../hooks/context/useSettings';
import { getClipboardContent } from '../../blue_modules/clipboard';
import HandOffComponent from '../../components/HandOffComponent';
import { HandOffActivityType } from '../../components/types';
import WalletGradient from '../../class/wallet-gradient';
const buttonFontSize =
PixelRatio.roundToNearestPixel(Dimensions.get('window').width / 26) > 22
@ -53,7 +56,6 @@ const buttonFontSize =
type WalletTransactionsProps = NativeStackScreenProps<DetailViewStackParamList, 'WalletTransactions'>;
type RouteProps = RouteProp<DetailViewStackParamList, 'WalletTransactions'>;
type TransactionListItem = Transaction & { type: 'transaction' | 'header' };
const WalletTransactions: React.FC<WalletTransactionsProps> = ({ route }) => {
const { wallets, saveToDisk, setSelectedWalletID } = useStorage();
const { setReloadTransactionsMenuActionFunction } = useMenuElements();
@ -72,14 +74,6 @@ const WalletTransactions: React.FC<WalletTransactionsProps> = ({ route }) => {
const [lastFetchTimestamp, setLastFetchTimestamp] = useState(() => wallet?._lastTxFetch || 0);
const [fetchFailures, setFetchFailures] = useState(0);
const MAX_FAILURES = 3;
const scrollY = useRef(new Animated.Value(0)).current;
const [headerHeight, setHeaderHeight] = useState(0);
const headerTranslate = scrollY.interpolate({
inputRange: [0, headerHeight],
outputRange: [0, -headerHeight],
extrapolate: 'clamp',
});
const stylesHook = StyleSheet.create({
listHeaderText: {
@ -262,8 +256,11 @@ const WalletTransactions: React.FC<WalletTransactionsProps> = ({ route }) => {
);
const navigateToViewEditCosigners = useCallback(() => {
navigate('ViewEditMultisigCosigners', {
walletID,
navigate('ViewEditMultisigCosignersRoot', {
screen: 'ViewEditMultisigCosigners',
params: {
walletID,
},
});
}, [navigate, walletID]);
@ -283,11 +280,9 @@ const WalletTransactions: React.FC<WalletTransactionsProps> = ({ route }) => {
walletID,
},
});
} else if (wallet?.type === MultisigHDWallet.type) {
navigateToViewEditCosigners();
}
},
[name, navigate, navigateToViewEditCosigners, onWalletSelect, wallet?.type, walletID, wallets],
[name, navigate, onWalletSelect, walletID, wallets],
);
const getItemLayout = (_: any, index: number) => ({
@ -402,8 +397,7 @@ const WalletTransactions: React.FC<WalletTransactionsProps> = ({ route }) => {
console.debug('Next screen is focused, clearing reloadTransactionsMenuActionFunction');
setReloadTransactionsMenuActionFunction(() => {});
};
// eslint-disable-next-line react-hooks/exhaustive-deps
}, []),
}, [setReloadTransactionsMenuActionFunction, refreshTransactions]),
);
const [balance, setBalance] = useState(wallet ? wallet.getBalance() : 0);
@ -424,9 +418,8 @@ const WalletTransactions: React.FC<WalletTransactionsProps> = ({ route }) => {
const handleScroll = useCallback(
(event: any) => {
const offsetY = event.nativeEvent.contentOffset.y;
// Use the measured header height to determine when to show/hide the header title
const threshold = headerHeight * 0.75;
if (offsetY < threshold) {
const combinedHeight = 180;
if (offsetY < combinedHeight) {
setOptions({ ...getWalletTransactionsOptions({ route }), headerTitle: undefined });
} else {
navigation.setOptions({
@ -434,82 +427,104 @@ const WalletTransactions: React.FC<WalletTransactionsProps> = ({ route }) => {
});
}
},
[navigation, wallet, walletBalance, setOptions, route, headerHeight],
[navigation, wallet, walletBalance, setOptions, route],
);
// Extracted named callbacks
const handleWalletUnitChange = useCallback(
async (selectedUnit: any) => {
if (wallet) {
wallet.preferredBalanceUnit = selectedUnit;
await saveToDisk();
}
},
[wallet, saveToDisk],
);
const handleWalletBalanceVisibilityChange = useCallback(
async (isShouldBeVisible: boolean) => {
if (wallet) {
const isBiometricsEnabled = await isBiometricUseCapableAndEnabled();
if (wallet.hideBalance && isBiometricsEnabled) {
const unlocked = await unlockWithBiometrics();
if (!unlocked) throw new Error('Biometrics failed');
}
wallet.hideBalance = isShouldBeVisible;
await saveToDisk();
}
},
[wallet, saveToDisk, isBiometricUseCapableAndEnabled],
);
const handleHeaderLayout = useCallback((event: LayoutChangeEvent) => {
const { height } = event.nativeEvent.layout;
setHeaderHeight(height);
}, []);
const refreshProps =
!isDesktop && !isElectrumDisabled ? { onRefresh: refreshTransactions, progressViewOffset: headerHeight, refreshing: isLoading } : {};
const renderHeader = useCallback(() => {
return (
<View style={{ backgroundColor: colors.background }}>
<View style={styles.listHeaderTextRow}>
<Text style={[styles.listHeaderText, stylesHook.listHeaderText]}>{loc.transactions.list_title}</Text>
</View>
<View style={{ backgroundColor: colors.background }}>
{wallet?.type === WatchOnlyWallet.type && wallet.isWatchOnlyWarningVisible && (
<WatchOnlyWarning
handleDismiss={() => {
wallet.isWatchOnlyWarningVisible = false;
LayoutAnimation.configureNext(LayoutAnimation.Presets.linear);
saveToDisk();
}}
/>
)}
</View>
</View>
);
}, [colors.background, stylesHook.listHeaderText, wallet, saveToDisk]);
return (
<Animated.View style={styles.container}>
<Animated.View style={[styles.stickyHeader, { transform: [{ translateY: headerTranslate }] }]} onLayout={handleHeaderLayout}>
{wallet ? (
const ListHeaderComponent = useCallback(
() =>
wallet ? (
<>
<TransactionsNavigationHeader
wallet={wallet}
onWalletUnitChange={handleWalletUnitChange}
onWalletUnitChange={async selectedUnit => {
wallet.preferredBalanceUnit = selectedUnit;
await saveToDisk();
}}
unit={wallet.preferredBalanceUnit}
onWalletBalanceVisibilityChange={handleWalletBalanceVisibilityChange}
onManageFundsPressed={onManageFundsPressed}
onWalletBalanceVisibilityChange={async isShouldBeVisible => {
const isBiometricsEnabled = await isBiometricUseCapableAndEnabled();
if (wallet.hideBalance && isBiometricsEnabled) {
const unlocked = await unlockWithBiometrics();
if (!unlocked) throw new Error('Biometrics failed');
}
wallet.hideBalance = isShouldBeVisible;
await saveToDisk();
}}
onManageFundsPressed={id => {
if (wallet.type === MultisigHDWallet.type) {
navigateToViewEditCosigners();
} else if (wallet.type === LightningCustodianWallet.type) {
if (wallet.getUserHasSavedExport()) {
if (!id) return;
onManageFundsPressed(id);
} else {
presentWalletExportReminder()
.then(async () => {
if (!id) return;
wallet.setUserHasSavedExport(true);
await saveToDisk();
onManageFundsPressed(id);
})
.catch(() => {
navigate('WalletExportRoot', {
screen: 'WalletExport',
params: {
walletID,
},
});
});
}
}
}}
/>
) : null}
</Animated.View>
<Animated.FlatList<Transaction>
<>
<View style={[styles.flex, { backgroundColor: colors.background }]}>
<View style={styles.listHeaderTextRow}>
<Text style={[styles.listHeaderText, stylesHook.listHeaderText]}>{loc.transactions.list_title}</Text>
</View>
</View>
<View style={{ backgroundColor: colors.background }}>
{wallet.type === WatchOnlyWallet.type && wallet.isWatchOnlyWarningVisible && (
<WatchOnlyWarning
handleDismiss={() => {
wallet.isWatchOnlyWarningVisible = false;
LayoutAnimation.configureNext(LayoutAnimation.Presets.linear);
saveToDisk();
}}
/>
)}
</View>
</>
</>
) : undefined,
[
wallet,
colors.background,
stylesHook.listHeaderText,
saveToDisk,
isBiometricUseCapableAndEnabled,
navigateToViewEditCosigners,
onManageFundsPressed,
navigate,
walletID,
],
);
return (
<View style={[styles.flex, { backgroundColor: colors.background }]}>
{/* The color of the refresh indicator. Temporary hack */}
<View
style={[
styles.refreshIndicatorBackground,
{ backgroundColor: wallet ? WalletGradient.headerColorFor(wallet.type) : colors.background },
]}
testID="TransactionsListView"
/>
<FlatList<Transaction>
getItemLayout={getItemLayout}
updateCellsBatchingPeriod={50}
onEndReachedThreshold={0.3}
ListHeaderComponent={renderHeader}
onEndReached={loadMoreTransactions}
ListFooterComponent={renderListFooterComponent}
data={getTransactions(limit)}
@ -517,22 +532,26 @@ const WalletTransactions: React.FC<WalletTransactionsProps> = ({ route }) => {
keyExtractor={_keyExtractor}
renderItem={renderItem}
initialNumToRender={10}
style={{ marginTop: headerHeight }}
removeClippedSubviews
contentContainerStyle={{ backgroundColor: colors.background }}
contentInset={{ top: 0, left: 0, bottom: 90, right: 0 }}
maxToRenderPerBatch={10}
testID="TransactionsListView"
onScroll={handleScroll}
scrollEventThrottle={16}
{...refreshProps}
stickyHeaderHiddenOnScroll
ListHeaderComponent={ListHeaderComponent}
ListEmptyComponent={
<View style={[styles.flex, { backgroundColor: colors.background }]} testID="TransactionsListEmpty">
<Text numberOfLines={0} style={styles.emptyTxs}>
<ScrollView style={[styles.flex, { backgroundColor: colors.background }]} contentContainerStyle={styles.scrollViewContent}>
<Text numberOfLines={0} style={styles.emptyTxs} testID="TransactionsListEmpty">
{(isLightning() && loc.wallets.list_empty_txs1_lightning) || loc.wallets.list_empty_txs1}
</Text>
{isLightning() && <Text style={styles.emptyTxsLightning}>{loc.wallets.list_empty_txs2_lightning}</Text>}
</View>
</ScrollView>
}
refreshControl={
!isDesktop && !isElectrumDisabled ? (
<RefreshControl refreshing={isLoading} onRefresh={() => refreshTransactions(true)} tintColor={colors.msSuccessCheck} />
) : undefined
}
windowSize={15}
maintainVisibleContentPosition={{
@ -579,27 +598,27 @@ const WalletTransactions: React.FC<WalletTransactionsProps> = ({ route }) => {
url={`https://www.blockonomics.co/#/search?q=${wallet.getXpub()}`}
/>
) : null}
</Animated.View>
</View>
);
};
export default WalletTransactions;
const styles = StyleSheet.create({
container: { flex: 1 },
flex: { flex: 1 },
scrollViewContent: { flex: 1, justifyContent: 'center', paddingHorizontal: 16, paddingBottom: 500 },
activityIndicator: { marginVertical: 20 },
listHeaderTextRow: { padding: 16, flexDirection: 'row' },
listHeaderText: { fontWeight: 'bold', fontSize: 24 },
emptyTxs: { fontSize: 18, color: '#9aa0aa', textAlign: 'center', marginVertical: 16 },
emptyTxsLightning: { fontSize: 18, color: '#9aa0aa', textAlign: 'center', fontWeight: '600' },
sendIcon: { transform: [{ rotate: I18nManager.isRTL ? '-225deg' : '225deg' }] },
receiveIcon: { transform: [{ rotate: I18nManager.isRTL ? '45deg' : '-45deg' }] },
stickyHeader: {
listHeaderTextRow: { flex: 1, margin: 16, flexDirection: 'row', justifyContent: 'space-between' },
listHeaderText: { marginTop: 8, marginBottom: 8, fontWeight: 'bold', fontSize: 24 },
refreshIndicatorBackground: {
position: 'absolute',
top: 0,
left: 0,
right: 0,
zIndex: 1,
height: 140,
},
emptyTxs: { fontSize: 18, color: '#9aa0aa', textAlign: 'center', marginVertical: 16 },
emptyTxsLightning: { fontSize: 18, color: '#9aa0aa', textAlign: 'center', fontWeight: '600' },
sendIcon: { transform: [{ rotate: I18nManager.isRTL ? '-225deg' : '225deg' }] },
receiveIcon: { transform: [{ rotate: I18nManager.isRTL ? '45deg' : '-45deg' }] },
});

View file

@ -758,7 +758,7 @@ describe('BlueWallet UI Tests - import BIP84 wallet', () => {
await waitForId('TransactionsListEmpty');
assert.strictEqual(await countElements('TransactionListItem'), 0);
await element(by.id('TransactionsListView')).swipe('down', 'slow', 0.5, 0.3); // pul-to-refresh
await element(by.id('TransactionsListView')).swipe('down', 'slow'); // pul-to-refresh
// asserting balance and txs loaded:
await waitForText('0.00105526'); // the wait inside allows network request to propagate