From b0db2e78d57ed2d44e2ee4829b473857739f179c Mon Sep 17 00:00:00 2001 From: Marcos Rodriguez Velez Date: Sat, 18 May 2024 00:32:47 -0400 Subject: [PATCH 1/4] FIX: Camera would not open in Electrum settings --- screen/settings/electrumSettings.js | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/screen/settings/electrumSettings.js b/screen/settings/electrumSettings.js index d23a44ad3..230a8b3f1 100644 --- a/screen/settings/electrumSettings.js +++ b/screen/settings/electrumSettings.js @@ -31,11 +31,12 @@ import { BlueCurrentTheme } from '../../components/themes'; import { reloadAllTimelines } from '../../components/WidgetCommunication'; import { BlueStorageContext } from '../../blue_modules/storage-context'; import presentAlert from '../../components/Alert'; -import { requestCameraAuthorization } from '../../helpers/scan-qr'; +import { scanQrHelper } from '../../helpers/scan-qr'; import Button from '../../components/Button'; import ListItem from '../../components/ListItem'; import triggerHapticFeedback, { HapticFeedbackTypes } from '../../blue_modules/hapticFeedback'; import * as BlueElectrum from '../../blue_modules/BlueElectrum'; +import { navigationRef } from '../../NavigationService'; export default class ElectrumSettings extends Component { static contextType = BlueStorageContext; @@ -225,17 +226,9 @@ export default class ElectrumSettings extends Component { }); }; - importScan = () => { - requestCameraAuthorization().then(() => - this.props.navigation.navigate('ScanQRCodeRoot', { - screen: 'ScanQRCode', - params: { - launchedBy: this.props.route.name, - onBarScanned: this.onBarScanned, - showFileImportButton: true, - }, - }), - ); + importScan = async () => { + const scanned = await scanQrHelper(navigationRef.navigate, 'ElectrumSettings', true); + this.onBarScanned(scanned); }; useSSLPortToggled = value => { From 21ff4dd6ee793192adb0f011ac730f6567296d7c Mon Sep 17 00:00:00 2001 From: Marcos Rodriguez Velez Date: Sat, 18 May 2024 00:36:03 -0400 Subject: [PATCH 2/4] FIX: Closing the scanner wouldnt remove the loading indicator --- screen/send/details.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/screen/send/details.js b/screen/send/details.js index 348398b43..a64c47fba 100644 --- a/screen/send/details.js +++ b/screen/send/details.js @@ -334,7 +334,7 @@ const SendDetails = () => { // we need to re-calculate fees if user opens-closes coin control useFocusEffect( useCallback(() => { - LayoutAnimation.configureNext(LayoutAnimation.Presets.easeInEaseOut); + setIsLoading(false); setDumb(v => !v); }, []), ); From 8936be34d500ad8dd966494fbf2a8e6cef267a9b Mon Sep 17 00:00:00 2001 From: Marcos Rodriguez Velez Date: Fri, 17 May 2024 18:48:00 -0400 Subject: [PATCH 3/4] Update TooltipMenu.ios.js --- components/TooltipMenu.ios.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/TooltipMenu.ios.js b/components/TooltipMenu.ios.js index 2325f37f8..29f982516 100644 --- a/components/TooltipMenu.ios.js +++ b/components/TooltipMenu.ios.js @@ -6,7 +6,7 @@ import { TouchableOpacity } from 'react-native'; const BaseToolTipMenu = (props, ref) => { const menuItemMapped = ({ action, menuOptions }) => { const item = { - actionKey: action.id, + actionKey: action.id.toString(), actionTitle: action.text, icon: action.icon, menuOptions, From a07f57d85ad7be7fff5db01aa6a8858aa4ed9578 Mon Sep 17 00:00:00 2001 From: overtorment Date: Sat, 18 May 2024 10:25:54 +0100 Subject: [PATCH 4/4] FIX: contact list tooltip --- screen/wallets/PaymentCodesList.tsx | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/screen/wallets/PaymentCodesList.tsx b/screen/wallets/PaymentCodesList.tsx index 475dd8597..a3c255884 100644 --- a/screen/wallets/PaymentCodesList.tsx +++ b/screen/wallets/PaymentCodesList.tsx @@ -107,7 +107,7 @@ export default function PaymentCodesList() { }; const onToolTipPress = async (id: any, pc: string) => { - if (id === Actions.copyToClipboard) { + if (String(id) === String(Actions.copyToClipboard)) { Clipboard.setString(pc); presentAlert({ message: loc.bip47.copied }); } @@ -256,12 +256,12 @@ const styles = StyleSheet.create({ }, sectionListContainer: { flex: 1, width: '100%' }, circle: { - width: 42, - height: 42, + width: 35, + height: 35, borderRadius: 25, }, contactRowBody: { flex: 6, justifyContent: 'center', top: -3 }, - contactRowNameText: { marginLeft: 10, fontSize: 20, fontWeight: 'bold' }, + contactRowNameText: { marginLeft: 10, fontSize: 16 }, contactRowContainer: { flexDirection: 'row', padding: 15 }, stick: { borderStyle: 'solid', borderWidth: 0.5, borderColor: 'gray', opacity: 0.5, top: 0, left: -10, width: '110%' }, });