From b7f72498f2c05d47c242d7220c0754fb3d1ec5bf Mon Sep 17 00:00:00 2001 From: ncoelho Date: Wed, 29 Apr 2020 15:59:47 +0200 Subject: [PATCH] remove 3rd button from ligthning wallets --- loc/en.js | 2 +- screen/wallets/transactions.js | 11 ++++++++++- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/loc/en.js b/loc/en.js index c8aee6eff..47ed634d7 100644 --- a/loc/en.js +++ b/loc/en.js @@ -27,7 +27,7 @@ module.exports = { empty_txs1_lightning: 'Lightning wallet should be used for your daily transactions. Fees are unfairly cheap and speed is blazing fast.', empty_txs2_lightning: '\nTo start using it tap on "manage funds" and topup your balance.', - tap_here_to_buy: 'buy Bitcoin', + tap_here_to_buy: 'Buy Bitcoin', }, reorder: { title: 'Reorder Wallets', diff --git a/screen/wallets/transactions.js b/screen/wallets/transactions.js index 2d1f44f38..686728d60 100644 --- a/screen/wallets/transactions.js +++ b/screen/wallets/transactions.js @@ -218,7 +218,16 @@ export default class WalletTransactions extends Component { return ( - {this.state.wallet.getTransactions().length > 0 && this.renderSellFiat()} + {/* + So the idea here, due to Apple banning native Lapp marketplace, is: + On Android everythins works as it worked before. Single "Marketplace" button that leads to LappBrowser that + opens /marketplace/ url of offchain wallet type, and /marketplace-btc/ for onchain is not, but on the details. + On iOS its more complicated - we have one button that opens same page _externally_ (in Safari), and second + button that opens actual LappBrowser but with _blank_ page. This is important to not trigger Apple. + Blank page is also the way Trust Wallet does it with Dapp Browser. + For ONCHAIN wallet type no LappBrowser button should be displayed, its Lightning-network specific. + */} + {this.state.wallet.getTransactions().length > 0 && this.state.wallet.type !== LightningCustodianWallet.type && this.renderSellFiat()} {this.state.wallet.type === LightningCustodianWallet.type && this.renderMarketplaceButton()} {this.state.wallet.type === LightningCustodianWallet.type && Platform.OS === 'ios' && this.renderLappBrowserButton()}