FIX: Refresh Transactions was failing on macOS

components/MenuElements.ios.tsx

@@ -45,11 +45,10 @@ const MenuElements = () => {
     if (reloadTransactionsMenuActionFunction && typeof reloadTransactionsMenuActionFunction === 'function') {
       reloadTransactionsMenuActionFunction();
     }
-    // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, []);
+  }, [reloadTransactionsMenuActionFunction]);
 
   useEffect(() => {
-    console.log('MenuElements: useEffect');
+    console.debug('MenuElements: useEffect');
     if (walletsInitialized) {
       eventEmitter?.addListener('openSettings', openSettings);
       eventEmitter?.addListener('addWalletMenuAction', addWalletMenuAction);
@@ -62,8 +61,7 @@ const MenuElements = () => {
       eventEmitter?.removeAllListeners('importWalletMenuAction');
       eventEmitter?.removeAllListeners('reloadTransactionsMenuAction');
     };
-    // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [walletsInitialized]);
+  }, [addWalletMenuAction, importWalletMenuAction, openSettings, reloadTransactionsMenuElementsFunction, walletsInitialized]);
 
   return null;
 };

components/TransactionsNavigationHeader.tsx

@@ -218,7 +218,7 @@ const TransactionsNavigationHeader: React.FC<TransactionsNavigationHeaderProps>
         <TouchableOpacity style={styles.walletPreferredUnitView} onPress={changeWalletBalanceUnit}>
           <Text style={styles.walletPreferredUnitText}>
             {wallet.getPreferredBalanceUnit() === BitcoinUnit.LOCAL_CURRENCY
-              ? preferredFiatCurrency?.endPointKey ?? FiatUnit.USD
+              ? (preferredFiatCurrency?.endPointKey ?? FiatUnit.USD)
               : wallet.getPreferredBalanceUnit()}
           </Text>
         </TouchableOpacity>

components/WalletsCarousel.tsx

@@ -248,7 +248,7 @@ export const WalletCarouselItem: React.FC<WalletCarouselItemProps> = React.memo(
     return (
       <Animated.View
         style={[
-          isLargeScreen || !horizontal ? [iStyles.rootLargeDevice, customStyle] : customStyle ?? { ...iStyles.root, width: itemWidth },
+          isLargeScreen || !horizontal ? [iStyles.rootLargeDevice, customStyle] : (customStyle ?? { ...iStyles.root, width: itemWidth }),
           { opacity, transform: [{ scale: scaleValue }] },
         ]}
       >
@@ -374,9 +374,7 @@ const WalletsCarousel = forwardRef<FlatListRefType, WalletsCarouselProps>((props
 
   const flatListRef = useRef<FlatList<any>>(null);
 
-  useImperativeHandle(
-    ref,
-    (): any => {
+  useImperativeHandle(ref, (): any => {
     return {
       scrollToEnd: (params: { animated?: boolean | null | undefined } | undefined) => flatListRef.current?.scrollToEnd(params),
       scrollToIndex: (params: {
@@ -396,9 +394,7 @@ const WalletsCarousel = forwardRef<FlatListRefType, WalletsCarouselProps>((props
       flashScrollIndicators: () => flatListRef.current?.flashScrollIndicators(),
       getNativeScrollRef: () => flatListRef.current?.getNativeScrollRef(),
     };
-    },
-    [],
-  );
+  }, []);
 
   const onScrollToIndexFailed = (error: { averageItemLength: number; index: number }): void => {
     console.debug('onScrollToIndexFailed');

screen/send/SendDetails.tsx

@@ -108,7 +108,7 @@ const SendDetails = () => {
   const [dumb, setDumb] = useState(false);
   const { isEditable } = routeParams;
   // if utxo is limited we use it to calculate available balance
-  const balance: number = utxo ? utxo.reduce((prev, curr) => prev + curr.value, 0) : wallet?.getBalance() ?? 0;
+  const balance: number = utxo ? utxo.reduce((prev, curr) => prev + curr.value, 0) : (wallet?.getBalance() ?? 0);
   const allBalance = formatBalanceWithoutSuffix(balance, BitcoinUnit.BTC, true);
 
   // if cutomFee is not set, we need to choose highest possible fee for wallet balance

screen/transactions/TransactionDetails.tsx

@@ -139,7 +139,7 @@ const TransactionDetails = () => {
             // okay, this txid _was_ with someone using payment codes, so we show the label edit dialog
             // and load user-defined alias for the pc if any
 
-            setCounterpartyLabel(counterpartyMetadata ? counterpartyMetadata[foundPaymentCode]?.label ?? '' : '');
+            setCounterpartyLabel(counterpartyMetadata ? (counterpartyMetadata[foundPaymentCode]?.label ?? '') : '');
             setIsCounterpartyLabelVisible(true);
             setPaymentCode(foundPaymentCode);
           }

screen/wallets/WalletTransactions.tsx

@@ -95,6 +95,7 @@ const WalletTransactions: React.FC<WalletTransactionsProps> = ({ route }) => {
   }, [getTransactions, limit, pageSize]);
 
   const refreshTransactions = useCallback(async () => {
+    console.debug('refreshTransactions, ', wallet?.getLabel());
     if (!wallet || isElectrumDisabled || isLoading) return;
     setIsLoading(true);
     let smthChanged = false;

screen/wallets/WalletsList.tsx

@@ -410,6 +410,7 @@ const WalletsList: React.FC = () => {
   }, [copyFromClipboard, onBarScanned, routeName]);
 
   const onRefresh = useCallback(() => {
+    console.debug('WalletsList onRefresh');
     refreshTransactions(true, false);
     // Optimized for Mac option doesn't like RN Refresh component. Menu Elements now handles it for macOS
   }, [refreshTransactions]);