mirrors/BlueWallet
1
0
Fork 0
mirror of https://github.com/BlueWallet/BlueWallet.git synced 2025-02-22 23:08:07 +01:00
Code Issues Projects Releases Packages Wiki Activity

fix for legacy-wallet.fetchTransactions() to not crash when vout for transaction is missing addresses.

Browse source
This commit is contained in:
Matt Gurzenski 2020-05-18 15:20:50 -04:00 • committed by Overtorment
parent c70ba87195
commit 116f3ae4df
2 changed files with 16 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
class/legacy-wallet.js
View file

@ -193,7 +193,7 @@ export class LegacyWallet extends AbstractWallet {
}
}
for (let vout of tx.vout) {
if (vout.scriptPubKey.addresses.indexOf(this.getAddress()) !== -1) {
if (vout.scriptPubKey.addresses && vout.scriptPubKey.addresses.indexOf(this.getAddress()) !== -1) {
// this TX is related to our address
let clonedTx = Object.assign({}, tx);
clonedTx.inputs = tx.vin.slice(0);

15
tests/integration/legacy-wallet.test.js
View file

@ -68,6 +68,21 @@ describe('LegacyWallet', function() {
}
});
it('can fetch TXs when addresses for vout are missing', async () => {
// Transaction with missing address output https://www.blockchain.com/btc/tx/d45818ae11a584357f7b74da26012d2becf4ef064db015a45bdfcd9cb438929d
let w = new LegacyWallet();
w._address = '1PVfrmbn1vSMoFZB2Ga7nDuXLFDyJZHrHK';
await w.fetchTransactions();
assert.ok(w.getTransactions().length > 0);
for (let tx of w.getTransactions()) {
assert.ok(tx.hash);
assert.ok(tx.value);
assert.ok(tx.received);
assert.ok(tx.confirmations > 1);
}
});
it('can fetch UTXO', async () => {
let w = new LegacyWallet();
w._address = '12c6DSiU4Rq3P4ZxziKxzrL5LmMBrzjrJX';